Make portal transitions more seamless #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adjusts look angles for a more seamless transition instead of snapping to looking directly away from the exit portal. See Javadoc on PortalEntity#transformLookAngle for more details. - Use entity and portal bounding box sizes to offset destination position from portal position instead of hardcoded values. This should improve handling for different sized entities. We add Shapes.EPSILON to the final position to avoid immediately colliding with the destination portal (this particular epsilon is not required, but we need one). - Add destination position offsets for keeping the entity's BB within the exit portals top/bottom when exiting horizontal portals. This prevents the entity from exiting into blocks adjacent to the portal and taking suffocation damage.
Reuse existing logic from the motion translation
There was a problem hiding this comment.
The changes look solid but I'd need to pull into the game and test properly. @Direwolf20-MC This is likely worth testing and pulling in if it works as you're expecting it to
|
Sorry it took me so long to get around to trying this :). Life's been busy and i haven't had a chance to work on my mods for a bit. I tested this and it feels pretty good :). I'll go ahead and pull it in, and see how the response from the playerbase is. Thank you for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.