Skip to content

chore(soroban): doc amount-bounds#212

Merged
1nonlypiece merged 2 commits intoDisciplr-Org:mainfrom
licette32:doc/amount-bounds
Apr 1, 2026
Merged

chore(soroban): doc amount-bounds#212
1nonlypiece merged 2 commits intoDisciplr-Org:mainfrom
licette32:doc/amount-bounds

Conversation

@licette32
Copy link
Copy Markdown
Contributor

Summary

Adds Rustdoc to MIN_AMOUNT, MAX_AMOUNT, and MAX_VAULT_DURATION constants,
explaining the 7-decimal stroop denomination used by USDC on Stellar.
Updates the README constants block to align with the documented values.

Changes

src/lib.rs

  • Added /// Rustdoc to MIN_AMOUNT, MAX_AMOUNT, and MAX_VAULT_DURATION
  • Documents stroop denomination (1 USDC = 10_000_000 stroops)
  • Documents enforcement behavior and error returned on violation

README.md

  • Updated Vault Constraints constants block with clearer decimal notation

Test results

60 tests, 0 failed

Security notes

Documentation-only change. No logic modified.
No new dependencies.

Closes #126

@drips-wave
Copy link
Copy Markdown

drips-wave bot commented Mar 30, 2026

@licette32 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@1nonlypiece 1nonlypiece merged commit 6bd94bb into Disciplr-Org:main Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MIN_AMOUNT and MAX_AMOUNT constants — document stroop decimals

2 participants