chore(soroban): test max-duration-boundary#214
Merged
1nonlypiece merged 2 commits intoDisciplr-Org:mainfrom Apr 1, 2026
Merged
chore(soroban): test max-duration-boundary#2141nonlypiece merged 2 commits intoDisciplr-Org:mainfrom
1nonlypiece merged 2 commits intoDisciplr-Org:mainfrom
Conversation
|
@licette32 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds boundary tests for MAX_VAULT_DURATION to explicitly verify that
exactly 365 days is accepted and 365 days + 1 second is rejected.
Changes
tests/create_vault.rsequal to start + MAX_VAULT_DURATION is created successfully
when duration exceeds MAX_VAULT_DURATION by 1 second
Test results
14 passed, 0 failed
Coverage
~97% baseline maintained.
Security notes
No logic modified. Tests only.
No new dependencies.
Closes #127