Implement asset transfer between branches#357
Merged
truthixify merged 5 commits intoDistinctCodes:mainfrom Oct 5, 2025
Merged
Conversation
|
@zachyo is attempting to deploy a commit to the naijabuz's projects Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
|
The CI is failing, please fix it. |
Contributor
Author
|
@truthixify all checks fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request implements the ability to transfer assets between different branches within the system. A new transfer_asset function allows an asset owner or an admin to move an asset to a new branch. The implementation ensures that the asset is correctly removed from the old branch's asset list and added to the new one. To ensure accountability, all asset transfers are now recorded in an audit log.
Additionally, a bug was identified and fixed where the branch_id in the Asset struct had a type mismatch (u64 instead of BytesN<32>), which would have prevented the transfer functionality from working correctly. Existing tests were updated to reflect this fix.
Changes Made
transfer_assetFunction: Added a new function to the AssetUpContract to handle the transfer of assets between branches.authorized users can perform transfers.
branch_idType Mismatch: Corrected the type of branch_id in the Asset struct from u64 to BytesN<32> to align with the branch ID type used throughout the contract.Testing
A new test file, tests/transfer.rs, was added with comprehensive tests for the asset transfer functionality, including:
Closes #253