Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event funding information #917

Merged
merged 3 commits into from
Dec 31, 2023

Conversation

amakarudze
Copy link
Contributor

Changes in this PR

  • Add event funding template, view, url and tests

@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2e328a2) 80.87% compared to head (da3fa59) 80.88%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #917      +/-   ##
==========================================
+ Coverage   80.87%   80.88%   +0.01%     
==========================================
  Files          95       95              
  Lines        2855     2857       +2     
  Branches      269      269              
==========================================
+ Hits         2309     2311       +2     
  Misses        494      494              
  Partials       52       52              
Files Coverage Δ
organize/urls.py 100.00% <ø> (ø)
organize/views.py 71.42% <100.00%> (+1.21%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e328a2...da3fa59. Read the comment docs.

templates/organize/event_funding.html Outdated Show resolved Hide resolved
tests/organize/test_views.py Show resolved Hide resolved
@amakarudze
Copy link
Contributor Author

amakarudze commented Nov 24, 2023

Thanks, @marksweb, I have been busy with DjangoCon Africa, so I can now look at this.

Flake 8 is passing locally but failing for all new pull requests and what it's suggesting seems pretty weird to me. Should we consider changing this action @marksweb?

@marksweb
Copy link
Sponsor Collaborator

@amakarudze yeah I see. With the slack message in the management utils it might be complaining about the slack emojis.

I'd have to have a look from my laptop to be sure. But I can look at ignoring things that are actually valid or changing for the ruff linter which is what use these days.

@amakarudze
Copy link
Contributor Author

Yeah I was thinking of using ruff instead @marksweb.

@marksweb
Copy link
Sponsor Collaborator

Ok I got ruff in quicker than expected. #923

@amakarudze amakarudze merged commit 5749485 into DjangoGirls:main Dec 31, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants