Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix MarkDown syntax in German translation #1462

Merged
merged 1 commit into from
Jan 26, 2019
Merged

Conversation

das-g
Copy link
Member

@das-g das-g commented Jan 14, 2019

(hopefully already fixed in Crowdin, although I'm not quite sure how that translates MarkDown to HTML and back again)

Changes in this pull request:

  • fix MarkDown syntax in German translation
  • add newline at end-of-file (GitHub's online editor did that automatically)

(hopefully already fixed in Crowdin, although I'm not quite sure how that translates MarkDown to HTML and back again)
@das-g
Copy link
Member Author

das-g commented Jan 14, 2019

/cc @DjangoGirls/de-pr

@das-g
Copy link
Member Author

das-g commented Jan 24, 2019

In #1468 (comment) @magul wrote:

Just quick note here (as I don't want to hijack discussion here), I believe that what You want to resolve in #1462 is actually caused by Crowdin issue with rendering these few tags in destination language, so if You're figuring out this one You can ask them for support regarding this issue also.

Yeah, that's a good idea. I think we don't even have to wait until #1468 is figured out. Can you (@magul) or some other "manager" of https://crowdin.com/project/django-girls-tutorial contact them, though? I'm unfamiliar with our import/export procedure, so I can't give any information about that if it should be needed.

What you'll probably need to provide is a link to the affected string on Crowdin. You can get that in the translation view on Crowdin by clicking on next to "Text for translation" when the affected string is selected in the left pane.

E.g. for German, it'd be https://crowdin.com/translate/django-girls-tutorial/313/en-de#9986

They may also want the source file, i.e. https://raw.githubusercontent.com/DjangoGirls/tutorial/master/en/html/README.md

@das-g
Copy link
Member Author

das-g commented Jan 24, 2019

Though, may I suggest you merge this PR anyway, as a temporary fix?

It probably doesn't even need review from @DjangoGirls/de-pr, as it only changes (and fixes) markup and doesn't change any actual content.

@magul magul merged commit 694f884 into DjangoGirls:master Jan 26, 2019
@magul
Copy link
Member

magul commented Jan 26, 2019

@das-g I just merged it and agree that's only a temporary fix. We should work with Crowdin support if they are able to fix it or we should look for a workaround here (I will also ask them if they can provide one).

@das-g
Copy link
Member Author

das-g commented Jan 26, 2019

Maybe Crowdin already noticed and fixed it. When I change the strings back to containing the appropriate placeholders instead of HTML-escaped gibberish, the translation I can get through the "download and upload" menu looks correct.

@das-g das-g deleted the patch-3 branch January 26, 2019 16:50
@magul
Copy link
Member

magul commented Jan 26, 2019

@das-g I will try to create a new German translation update (in 2 hours or so), so we would be able to check if it works the same way when using Crowdin API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants