Skip to content

Update: footer links #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nikuunj wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update: footer links #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions src/sections/Footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,22 +13,26 @@ export const Footer = () => {
<div className="font-medium text-sm sm:text-base">StablePay</div>
</div>
<nav className="flex flex-wrap justify-center gap-x-4 gap-y-2 sm:gap-4 w-full sm:w-auto lg:flex-1 lg:justify-center">
<a href="#" className="text-white/70 hover:text-white text-xs sm:text-sm transition">
<a href="https://docs.stability.nexus/about-us/the-djed-alliance" className="text-white/70 hover:text-white text-xs sm:text-sm transition">
Features
</a>
<a href="#" className="text-white/70 hover:text-white text-xs sm:text-sm transition">
<a href="https://docs.stability.nexus/about-us/the-djed-alliance" className="text-white/70 hover:text-white text-xs sm:text-sm transition">
Docs
</a>
<a href="#" className="text-white/70 hover:text-white text-xs sm:text-sm transition">
<a href="https://medium.com/djed-alliance" className="text-white/70 hover:text-white text-xs sm:text-sm transition">
Blog
</a>
<a href="#" className="text-white/70 hover:text-white text-xs sm:text-sm transition">
<a href="https://github.com/DjedAlliance" className="text-white/70 hover:text-white text-xs sm:text-sm transition">
Github
</a>
Comment on lines +16 to 27

@coderabbitai coderabbitai Bot Jan 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Features and Docs links point to the same URL; add security attributes for external links.

Two issues identified:

  1. Duplicate URL (lines 16 and 19): Both "Features" and "Docs" navigate to the same URL (https://docs.stability.nexus/about-us/the-djed-alliance). This is likely unintentional and creates a confusing user experience.

  2. Missing security and UX attributes: External links should include target="_blank" and rel="noopener noreferrer" to open in a new tab and prevent potential security vulnerabilities via window.opener.

🔗 Proposed fix 
-              <a href="https://docs.stability.nexus/about-us/the-djed-alliance" className="text-white/70 hover:text-white text-xs sm:text-sm transition">
+              <a href="https://docs.stability.nexus/about-us/the-djed-alliance" target="_blank" rel="noopener noreferrer" className="text-white/70 hover:text-white text-xs sm:text-sm transition">
                 Features
               </a>
-              <a href="https://docs.stability.nexus/about-us/the-djed-alliance" className="text-white/70 hover:text-white text-xs sm:text-sm transition">
+              <a href="[CORRECT_DOCS_URL]" target="_blank" rel="noopener noreferrer" className="text-white/70 hover:text-white text-xs sm:text-sm transition">
                 Docs
               </a>
-              <a href="https://medium.com/djed-alliance" className="text-white/70 hover:text-white text-xs sm:text-sm transition">
+              <a href="https://medium.com/djed-alliance" target="_blank" rel="noopener noreferrer" className="text-white/70 hover:text-white text-xs sm:text-sm transition">
                 Blog
               </a>
-              <a href="https://github.com/DjedAlliance" className="text-white/70 hover:text-white text-xs sm:text-sm transition">
+              <a href="https://github.com/DjedAlliance" target="_blank" rel="noopener noreferrer" className="text-white/70 hover:text-white text-xs sm:text-sm transition">
                 Github
               </a>

Replace [CORRECT_DOCS_URL] with the intended documentation URL.

🤖 Prompt for AI Agents 
In @src/sections/Footer.tsx around lines 16 - 27, In Footer.tsx the "Features"
and "Docs" anchors both point to the same URL and external anchors lack security
attributes; update the "Docs" anchor's href to the correct documentation URL
(replace the duplicated https://docs.stability.nexus/about-us/the-djed-alliance
with the intended docs URL for the element labeled "Docs") and add
target="_blank" and rel="noopener noreferrer" to all external <a> elements (the
anchors labeled "Features", "Docs", "Blog", "Github") so they open in a new tab
securely.

</nav>
<div className="flex gap-4 sm:gap-5 justify-center w-full sm:w-auto lg:flex-1 lg:justify-end">
<XSocial className="text-white/40 hover:text-white transition w-5 h-5 sm:w-6 sm:h-6" />
<YTSocial className="text-white/40 hover:text-white transition w-5 h-5 sm:w-6 sm:h-6" />
<a href={"https://x.com/DjedAlliance"}>
<XSocial className="text-white/40 hover:text-white transition w-5 h-5 sm:w-6 sm:h-6" />
</a>
<a href={"https://www.youtube.com/watch?v=v_9NHSBhWvs&t=6s"}>
<YTSocial className="text-white/40 hover:text-white transition w-5 h-5 sm:w-6 sm:h-6" />
</a>
Comment on lines +30 to +35

@coderabbitai coderabbitai Bot Jan 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Add security and accessibility attributes; verify YouTube link target.

Several issues with the social media links:

  1. Missing security attributes: External links require target="_blank" and rel="noopener noreferrer" for security and UX.

  2. Missing accessibility labels: Icon-only links need aria-label attributes so screen reader users can identify their purpose.

  3. YouTube link specificity: The YouTube link points to a specific video with a timestamp rather than the channel page. Verify this is intentional.

  4. Unnecessary curly braces: The href values don't need curly braces around string literals.

🔗 Proposed fix 
-              <a href={"https://x.com/DjedAlliance"}>
+              <a href="https://x.com/DjedAlliance" target="_blank" rel="noopener noreferrer" aria-label="Follow us on X (Twitter)">
                 <XSocial className="text-white/40 hover:text-white transition w-5 h-5 sm:w-6 sm:h-6" />
               </a>
-              <a href={"https://www.youtube.com/watch?v=v_9NHSBhWvs&t=6s"}>
+              <a href="https://www.youtube.com/@DjedAlliance" target="_blank" rel="noopener noreferrer" aria-label="Subscribe to our YouTube channel">
                 <YTSocial className="text-white/40 hover:text-white transition w-5 h-5 sm:w-6 sm:h-6" />
               </a>

Note: Replace https://www.youtube.com/@DjedAlliance with the correct channel URL if different, or keep the specific video URL if that's intentional.

🤖 Prompt for AI Agents 
In @src/sections/Footer.tsx around lines 30 - 35, Update the two social anchor
elements wrapping XSocial and YTSocial: remove unnecessary curly braces around
the href string literals, add target="_blank" and rel="noopener noreferrer" to
open external links securely, and add descriptive aria-label attributes (e.g.,
aria-label="X (formerly Twitter)" and aria-label="YouTube") so the icon-only
links are accessible; also confirm whether the YTSocial href should point to the
channel URL (e.g., https://www.youtube.com/@DjedAlliance) instead of the
specific video URL and update if needed.

</div>
</div>
</div>
Expand Down