Add GitHub link to footer - #63
Open
raj-aryan-official wants to merge 2 commits into
Open
Conversation
📝 WalkthroughWalkthroughAdded a default Head component supplying favicon and theme-color meta tags; updated the Footer GitHub link URL, corrected its label to "GitHub", and set it to open securely in a new tab. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (3 warnings)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/sections/Footer.tsx (1)
25-32: Consider adding screen reader indication for new tab behavior.The link opens in a new tab but does not inform screen reader users of this behavior. Adding an
aria-labelor visually hidden text improves accessibility.♿ Proposed accessibility improvement
<a href="https://github.com/DjedAlliance/StablePay-LandingPage" target="_blank" rel="noopener noreferrer" + aria-label="GitHub (opens in new tab)" className="text-white/70 hover:text-white text-xs sm:text-sm transition" > GitHub </a>🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/sections/Footer.tsx` around lines 25 - 32, The GitHub anchor in the Footer component currently opens a new tab (target="_blank") but lacks screen-reader indication; update the anchor (the <a> element linking to "https://github.com/DjedAlliance/StablePay-LandingPage" in Footer.tsx) to include an accessible cue such as adding an aria-label like "GitHub (opens in new tab)" or adding a visually hidden span (e.g., className="sr-only") that reads "opens in new tab" so assistive technologies announce the new-tab behavior; keep existing target and rel attributes (consider adding noopener if not present) and ensure the visible text remains "GitHub".
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/sections/Footer.tsx`:
- Around line 25-32: The anchor element in the Footer component that links to
the GitHub repo uses rel="noreferrer" only; update that <a> (the GitHub link) to
include both noopener and noreferrer (e.g., rel="noopener noreferrer") to ensure
defensive compatibility and explicit opener isolation when target="_blank" is
used.
---
Nitpick comments:
In `@src/sections/Footer.tsx`:
- Around line 25-32: The GitHub anchor in the Footer component currently opens a
new tab (target="_blank") but lacks screen-reader indication; update the anchor
(the <a> element linking to
"https://github.com/DjedAlliance/StablePay-LandingPage" in Footer.tsx) to
include an accessible cue such as adding an aria-label like "GitHub (opens in
new tab)" or adding a visually hidden span (e.g., className="sr-only") that
reads "opens in new tab" so assistive technologies announce the new-tab
behavior; keep existing target and rel attributes (consider adding noopener if
not present) and ensure the visible text remains "GitHub".
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
src/app/head.tsx (1)
4-5: Redundant duplicate favicon link.Lines 4 and 5 both declare
rel="icon"pointing to the same file. Thesizes="any"attribute on line 5 is the SVG default behavior, making line 5 effectively redundant.♻️ Proposed simplification
- <link rel="icon" href="/favicon.svg" /> - <link rel="icon" href="/favicon.svg" sizes="any" /> + <link rel="icon" href="/favicon.svg" type="image/svg+xml" />🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/app/head.tsx` around lines 4 - 5, Remove the redundant duplicate favicon link: there are two <link rel="icon" href="/favicon.svg" /> entries (one with sizes="any"); keep a single favicon <link> (either plain or with sizes="any") and delete the other to avoid duplicate declarations in head.tsx.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/app/head.tsx`:
- Line 6: Replace the SVG apple-touch-icon with a proper PNG asset and add a
size attribute: change the existing <link rel="apple-touch-icon"
href="/favicon.svg" /> usage by linking to a 180x180 PNG (e.g.,
"/apple-touch-icon.png") and include sizes="180x180" to ensure iOS picks the
correct image; you can keep the SVG favicon for browsers but ensure the
apple-touch-icon link and filename reference a generated 180×180 PNG so iOS
home-screen icons render reliably.
- Around line 1-10: Remove the Head component (function Head in head.tsx)
entirely; stop using link/meta tags there and instead rely on file-based icons
by placing favicon.svg next to your app layout so Next automatically serves it
as the favicon; then add an export named viewport in your layout file (export
const viewport = { ... }) to configure the theme color (replacing the meta
theme-color) and, if you need Apple touch support, add a separate apple-icon
file next to the layout and reference it via file-based assets rather than
head.tsx.
---
Nitpick comments:
In `@src/app/head.tsx`:
- Around line 4-5: Remove the redundant duplicate favicon link: there are two
<link rel="icon" href="/favicon.svg" /> entries (one with sizes="any"); keep a
single favicon <link> (either plain or with sizes="any") and delete the other to
avoid duplicate declarations in head.tsx.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: ebfe818b-412f-435f-911d-334d89098e52
⛔ Files ignored due to path filters (1)
public/favicon.svgis excluded by!**/*.svg
📒 Files selected for processing (1)
src/app/head.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: Fix footer GitHub link
Addressed issue:
Fixes #6
What I changed:
I updated the GitHub link in the footer so that it correctly points to the official repository. I also ensured that the link opens in a new tab with the appropriate attributes.
Testing:
I tested the change locally and verified that the link redirects properly.
Notes:
This is a small fix to improve navigation and make sure users are directed to the correct GitHub repository. No other parts of the UI were modified.
Checklist:
This PR addresses a single issue
Code follows the project’s style and conventions
Changes tested locally
No new warnings or errors
Summary by CodeRabbit
New Features
Bug Fixes