fixing bug "pie char is not shown when only one option has votes" #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (we must draw a circle not a path)
|
+1 |
|
I've added a fix in issue #156, which removes the stroke from the sectors valued at 0 |
ghost
assigned 
| var ipath = sector(cx, cy, 1, angle, angle - 360 * values[i] / total).join(","); | ||
| //if all votes are in only one option must draw a circle | ||
| if (values[i] / total === 1) { | ||
| var circle = paper.circle(cx, cy, r).attr({ fill: chartinst.colors[i], stroke: opts.stroke || "#fff", "stroke-width": opts.strokewidth == null ? 1 : opts.strokewidth }); |
There was a problem hiding this comment.
This line should be:
var circle = paper.circle(cx, cy, r).attr({ fill: opts.colors && opts.colors[i] || chartinst.colors[i], stroke: opts.stroke || "#fff", "stroke-width": opts.strokewidth == null ? 1 : opts.strokewidth });
Otherwise you're not getting the colors set up in options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the problem was.. when we have more than one option and all votes are in only one of them.
the scripts tries to draw an arc using paper.path.. starting at a position and ending at the same position,
because the positions are the same this doesn't draw anything.
so I've added a fix..
if the option 's value is equal to the total then draw a circle.
I've also minified the file
regards