Conversation
권한 회수(revoke) 버튼이 확인 없이 즉시 DELETE를 호출하던 문제를 막는다. 문서 삭제·역할 회수·컬렉션 삭제와 동일한 window.confirm 컨벤션을 따라 리소스·대상·권한 종류를 표시하고 확인받는다.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경 내용
revoke) 버튼이 확인 절차 없이 클릭 즉시 DELETE를 호출하던 문제를 막습니다.DocumentsPage)·역할 회수(AdminPages)·컬렉션 삭제(CollectionsPage)와 동일한window.confirm컨벤션을 그대로 재사용해, 회수 대상 리소스·대상(사용자/역할/부서)·권한 종류를 확인 메시지에 표시합니다.disabled={busy}로 이미 충족돼 있어 추가 작업하지 않았습니다.검증
npx eslint app/features/PermissionsPage.tsx통과npm run test(프로덕션 빌드 + 테스트 19개) 전체 통과, 회귀 없음Closes #262