docs: MCP 도메인 주석/Javadoc 정리 - #290
Merged
Merged
Conversation
- 클래스 레벨 Javadoc 신규 추가(McpAccessToken, DocGridMcpTools, McpAccessTokenConverter 등) - 코드로 자명한 WHAT 주석 제거, WHY만 남기거나 실제 선언 위 Javadoc으로 이동 - SecurityConfig: "최종 인증 판정" → "최종 인가 판정" 등 부정확한 표현 정정 - McpApiKeyAuthFilter: 미인증 응답이 403이라는 주석을 실제 동작(401, RestAuthenticationEntryPoint)에 맞게 정정 - 응답 DTO 4종에 앱 전체 관례(@Schema 클래스 레벨 description)를 맞춤 로직 변경 없음, 컴파일 및 MCP 도메인 테스트 통과 확인. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (13)
📝 WalkthroughWalkthroughMCP 토큰 응답 DTO에 Swagger 설명을 추가했습니다. 토큰, 인증 필터, 요청 제한, 도구 실행, 보안 설정, MVC 인터셉터의 JavaDoc과 주석을 정비했습니다. 실행 로직과 공개 메서드 시그니처는 변경하지 않았습니다. ChangesMCP 문서화 정비
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@Schema추가(앱 전체 관례에 맞춤)Test plan
./backend/gradlew -p backend compileJava통과./backend/gradlew -p backend test --tests "com.opensource.docgrid.domain.mcp.*"통과🤖 Generated with Claude Code
Summary by CodeRabbit