Skip to content

[Fix] get_document_detail이 삭제된 문서를 걸러내지 않던 문제 수정 - #293

Merged
kangcheolung merged 2 commits into
developfrom
fix/291
Aug 24, 2026
Merged

[Fix] get_document_detail이 삭제된 문서를 걸러내지 않던 문제 수정#293
kangcheolung merged 2 commits into
developfrom
fix/291

Conversation

@kangcheolung

Copy link
Copy Markdown
Member

Summary

  • DocGridMcpTools.getDocumentDetail()DocumentStatus.DELETED 체크 추가
  • 형제 도구 get_indexing_status(DocumentQueryService.getDocumentStatus())와의 비대칭 해소 — 소프트 삭제된 문서를 조회하면 이제 동일하게 DOCUMENT_NOT_FOUND를 반환

closes #291

Test plan

  • getDocumentDetail_throws_when_documentDeleted 신규 단위 테스트 추가
  • ./backend/gradlew -p backend test 전체 통과

🤖 Generated with Claude Code

kangcheolung and others added 2 commits August 24, 2026 14:26
DocGridMcpTools.getDocumentDetail()에 DELETED 상태 체크가 없어, 형제 도구인
get_indexing_status(DocumentQueryService.getDocumentStatus())와 달리 소프트
삭제된 문서도 정상 응답으로 노출되던 비대칭을 해소.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 42 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 53e03940-42ff-466a-ab6e-ab65dbc272df

📥 Commits

Reviewing files that changed from the base of the PR and between 9cf27ec and 862a490.

📒 Files selected for processing (2)
  • backend/src/main/java/com/opensource/docgrid/domain/mcp/tool/DocGridMcpTools.java
  • backend/src/test/java/com/opensource/docgrid/domain/mcp/tool/DocGridMcpToolsTest.java

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kangcheolung kangcheolung changed the title fix: #291 get_document_detail이 삭제된 문서를 걸러내지 않던 문제 수정 [Fix] get_document_detail이 삭제된 문서를 걸러내지 않던 문제 수정 Aug 24, 2026
@kangcheolung
kangcheolung merged commit b2487fc into develop Aug 24, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Fix] MCP get_document_detail이 삭제된 문서를 걸러내지 않던 문제 수정

1 participant