[Fix] get_document_detail이 삭제된 문서를 걸러내지 않던 문제 수정 - #293
Merged
Conversation
DocGridMcpTools.getDocumentDetail()에 DELETED 상태 체크가 없어, 형제 도구인 get_indexing_status(DocumentQueryService.getDocumentStatus())와 달리 소프트 삭제된 문서도 정상 응답으로 노출되던 비대칭을 해소. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 42 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DocGridMcpTools.getDocumentDetail()에DocumentStatus.DELETED체크 추가get_indexing_status(DocumentQueryService.getDocumentStatus())와의 비대칭 해소 — 소프트 삭제된 문서를 조회하면 이제 동일하게DOCUMENT_NOT_FOUND를 반환closes #291
Test plan
getDocumentDetail_throws_when_documentDeleted신규 단위 테스트 추가./backend/gradlew -p backend test전체 통과🤖 Generated with Claude Code