[Fix] McpRateLimiter의 windows 맵이 TTL 없이 무한정 커지는 문제 수정 - #294
Merged
Conversation
ConcurrentHashMap을 Caffeine 캐시(expireAfterAccess 2분)로 교체해, 한 번이라도 호출된 사용자·도구 조합이 서버 재시작 전까지 메모리에 영구히 쌓이던 문제를 해소. checkLimit()의 rate limit 로직(고정 윈도우 판단/리셋/증가) 자체는 변경 없음. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 26 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
McpRateLimiter의windows맵을ConcurrentHashMap→ Caffeine 캐시(expireAfterAccess2분)로 교체checkLimit()의 rate limit 로직(고정 윈도우 판단/리셋/증가) 자체는 변경 없음#117에 알려진 한계로 남아있던 이슈를 해소 (신규 발견 아님)closes #292
Test plan
checkLimit_evictsEntry_afterTtlExpires신규 단위 테스트 추가./backend/gradlew -p backend test전체 통과문서
docs/design/kangcheolung-#292-mcp-rate-limiter-ttl.md🤖 Generated with Claude Code