Skip to content

TOTP configuration is hard-coded to SHA1 and fixed parameters #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
llinsss merged 3 commits into from
Mar 27, 2026
Merged

TOTP configuration is hard-coded to SHA1 and fixed parameters #377

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1249b7c
fix(2fa): remove unused imports, guarantee backup code uniqueness, re…
caramel222 Mar 26, 2026
c902021
Merge branch 'main' into fix/totp-hardcoded-params
caramel222 Mar 26, 2026
4ef99f1
Merge branch 'main' into fix/totp-hardcoded-params
llinsss Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion backend-2fa-implementation/src/two_factor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ use totp_rs::{Algorithm, Secret, TOTP};
use rand::distributions::{Distribution, Uniform};
use rand::thread_rng;
use rand::Rng;
use std::collections::HashSet;
use serde::{Deserialize, Serialize};
use std::collections::HashMap;
use std::sync::{Arc, Mutex};
Expand Down Expand Up @@ -184,7 +185,7 @@ impl TwoFactorAuth {

pub fn generate_backup_codes(count: usize) -> Vec<String> {
let mut rng = rand::thread_rng();
let mut codes = std::collections::HashSet::new();
let mut codes = HashSet::new();
while codes.len() < count {
codes.insert(format!("{:04}-{:04}", rng.gen_range(0..10000), rng.gen_range(0..10000)));
}
Expand Down
Loading