Skip to content

fix: improve birthday parsing with proper validation and format support#383

Merged
llinsss merged 3 commits intoDogStark:mainfrom
dreamgenies:fix/324-birthday-parsing
Mar 30, 2026
Merged

fix: improve birthday parsing with proper validation and format support#383
llinsss merged 3 commits intoDogStark:mainfrom
dreamgenies:fix/324-birthday-parsing

Conversation

@dreamgenies
Copy link
Copy Markdown
Contributor

Improves birthday parsing by supporting both unix timestamps and ISO date format.

Stacked on top of #382 until the earlier PRs merge.

  • Adds deterministic validation with Result-based errors
  • Supports YYYY-MM-DD parsing
  • Prevents silent incorrect calculations
  • Adds test coverage for all formats

closes #324

@drips-wave
Copy link
Copy Markdown

drips-wave bot commented Mar 30, 2026

@dreamgenies Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@llinsss llinsss merged commit dae4a38 into DogStark:main Mar 30, 2026
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

parse_birthday_timestamp expects digits-only timestamps; format expectations are unclear

2 participants