Expand treejs-arena prompt set to 25 scenes - #46
Merged
Conversation
Add five prompts covering capability axes the frozen set missed: a PlayStation 5 DualSense controller (hard-surface product modeling), a tripod-gait hexapod (articulated motion), a domino chain (rigid-body collision), an L-system tree (recursive geometry), and a reflective pool (planar reflection). Bump PROMPT_SET_VERSION to v2 so screenshots from v1 runs stay comparable, and update the counts in the README, registry description and tests. Validated with `uv run pytest` and `uv run benchkit --list`. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BMNSQS8H71wZgxgfcapymT
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThe Three.js Arena prompt set advances from v1 to v2. Five prompts are added, increasing the validated benchmark size from 20 to 25. Related descriptions and documentation no longer hard-code the former prompt count. ChangesThree.js Arena prompt expansion
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
treejs-arenanow ships 25 frozen prompts instead of 20. The five new scenes cover capability axes the existing set did not touch: hard-surface product modeling, articulated motion, rigid-body collision, recursive procedural geometry, and planar reflection.ps5-gamepadhexapod-walkdomino-chainl-system-treereflective-poolThe prompts are appended, so existing slugs and
TreeJSArena/<index>ids are unchanged and no shipped prompt was edited in place.PROMPT_SET_VERSIONmoves fromv1tov2because the denominator behind a run's render rate changed, and runs should not be compared across that boundary. Scoring, artifact handling, and the gallery are untouched.Wording follows the existing creative prompts: only
hexapod-walkcarries a spec clause ("feet staying planted"), because foot skating is the visible failure mode. The rest stay open-ended, since these scenes have no ground truth and an enumerated part list would just hand the model a checklist.Benchmark or dataset files touched
src/benchkit/benchmarks/treejs_arena.py— five prompts appended,PROMPT_SET_VERSIONbumped tov2, class docstring no longer hardcodes a count.src/benchkit/benchmarks/__init__.py— registry description no longer says "twenty".tests/test_treejs_arena.py— prompt-set count assertions updated to 25.README.md— benchmark table count 20 → 25.AGENTS.md— creative rendering section no longer hardcodes a count.No dataset files changed; this suite generates its prompts in code.
Validation
The render path itself was not exercised here — this container has no browser, and the new prompts reuse the existing rendering and scoring code unchanged.
Notes
--listoutput above; the task count is the only CLI-visible change.🤖 Generated with Claude Code
https://claude.ai/code/session_01BMNSQS8H71wZgxgfcapymT
Generated by Claude Code
Summary by CodeRabbit
New Features
Documentation