Skip to content

fix(backups): web-server backups auto-deletion #1616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Siumauricio merged 3 commits into from
Apr 6, 2025
Merged

fix(backups): web-server backups auto-deletion #1616

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
94c947e
fix(backups): web-server backups auto-deletion
vicke4 Apr 3, 2025
e176def
[autofix.ci] apply automated fixes
autofix-ci[bot] Apr 3, 2025
6cb4159
Merge branch 'Dokploy:canary' into webserver-backup-auto-delete
vicke4 Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/server/src/utils/backups/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,8 @@ export const keepLatestNBackups = async (
backup.prefix,
);

// --include "*.sql.gz" ensures nothing else other than the db backup files are touched by rclone
const rcloneList = `rclone lsf ${rcloneFlags.join(" ")} --include "*.sql.gz" ${backupFilesPath}`;
// --include "*.sql.gz" or "*.zip" ensures nothing else other than the dokploy backup files are touched by rclone
const rcloneList = `rclone lsf ${rcloneFlags.join(" ")} --include "*${backup.databaseType === "web-server" ? ".zip" : ".sql.gz"}" ${backupFilesPath}`;
// when we pipe the above command with this one, we only get the list of files we want to delete
const sortAndPickUnwantedBackups = `sort -r | tail -n +$((${backup.keepLatestCount}+1)) | xargs -I{}`;
// this command deletes the files
Expand Down