Skip to content

Fix: Increase maxBuffer for exec functions to support large database restores #3355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 4 commits into
base: canary
Choose a base branch
from
+30 −18
Draft

Fix: Increase maxBuffer for exec functions to support large database restores #3355

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
19b3dde
Initial plan
Copilot Dec 28, 2025
34d8603
Fix: Add maxBuffer option to execAsync functions to handle large back…
Copilot Dec 28, 2025
222bcba
Refactor: Extract MAX_EXEC_BUFFER_SIZE constant and add maxBuffer to …
Copilot Dec 28, 2025
e416aa6
Improve: Use consistent ExecOptions type and proper fallback for maxB…
Copilot Dec 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 30 additions & 18 deletions packages/server/src/utils/process/execAsync.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,19 @@ export { ExecError } from "./ExecError";

const execAsyncBase = util.promisify(exec);

// Set maxBuffer to 100MB to handle large backup restore operations
// Default is 1MB which can cause "maxBuffer length exceeded" errors
const MAX_EXEC_BUFFER_SIZE = 100 * 1024 * 1024;

export const execAsync = async (
command: string,
options?: { cwd?: string; env?: NodeJS.ProcessEnv; shell?: string },
options?: ExecOptions & { shell?: string },
): Promise<{ stdout: string; stderr: string }> => {
try {
const result = await execAsyncBase(command, options);
const result = await execAsyncBase(command, {
...options,
maxBuffer: options?.maxBuffer ?? MAX_EXEC_BUFFER_SIZE,
});
return {
stdout: result.stdout.toString(),
stderr: result.stderr.toString(),
Expand Down Expand Up @@ -43,6 +50,7 @@ export const execAsync = async (
interface ExecOptions {
cwd?: string;
env?: NodeJS.ProcessEnv;
maxBuffer?: number;
}

export const execAsyncStream = (
Expand All @@ -54,22 +62,26 @@ export const execAsyncStream = (
let stdoutComplete = "";
let stderrComplete = "";

const childProcess = exec(command, options, (error) => {
if (error) {
reject(
new ExecError(`Command execution failed: ${error.message}`, {
command,
stdout: stdoutComplete,
stderr: stderrComplete,
// @ts-ignore
exitCode: error.code,
originalError: error,
}),
);
return;
}
resolve({ stdout: stdoutComplete, stderr: stderrComplete });
});
const childProcess = exec(
command,
{ ...options, maxBuffer: options?.maxBuffer ?? MAX_EXEC_BUFFER_SIZE },
(error) => {
if (error) {
reject(
new ExecError(`Command execution failed: ${error.message}`, {
command,
stdout: stdoutComplete,
stderr: stderrComplete,
// @ts-ignore
exitCode: error.code,
originalError: error,
}),
);
return;
}
resolve({ stdout: stdoutComplete, stderr: stderrComplete });
},
);

childProcess.stdout?.on("data", (data: Buffer | string) => {
const stringData = data.toString();
Expand Down