Skip to content

Conversation

DomCR
Copy link
Owner

@DomCR DomCR commented Apr 27, 2025

Description

Investigation for MLeader objects not being correctly read by the DwgReader and written by DwgWriter.

Tasks done in this PR

Notes for reviewer

  • After reading the OpenDesign docs I've found some errors in the code; a missing flag version and some wrongly read values that where read in the wrong format.
  • The flag set as IF IsNewFormat OR DXF file has been removed because it was set as R2010 instead of a value in the APPID “ACAD_MLEADERVER”. This change seems to fix the older versions of the dwg but the value still is unknown for the reader and in some cases may cause to trigger an exception in the reader (not a breaking change if the Failsafe is on).
  • The last bit UnknownFlag298 seems to be present only for R2013Plus versions of dwg, this has been found by a manual investigation which may be wrongly assumed, to avoid the wrong values it will be set as an internal value.

@DomCR DomCR added enhancement New feature or request SPIKE Investigation related labels Apr 27, 2025
@mme1950
Copy link
Contributor

mme1950 commented Jul 22, 2025

Hi @DomCR,

does it make sense that I merge these channges into #658?

@DomCR
Copy link
Owner Author

DomCR commented Jul 22, 2025

Hi @mme1950

does it make sense that I merge these channges into #658?

I don't think so, this investigation is not conclusive, the problem still there, it won't solve anything.

@mme1950
Copy link
Contributor

mme1950 commented Jul 22, 2025

My problems with multileaders are solved with #658.
However you added some things, such as property default values, that my be helpful anyhow.

mme1950 added a commit to nanoLogika/ACadSharp that referenced this pull request Jul 22, 2025
mme1950 added a commit to nanoLogika/ACadSharp that referenced this pull request Jul 22, 2025
-  member sorting
-  property default values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request SPIKE Investigation related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants