fixes and search by value feature #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Domiii
reviewed
Dec 19, 2021
| /** @typedef {import('@dbux/common/src/types/DataNode').default} DataNode */ | ||
|
|
||
| /** @extends {CollectionIndex<DataNode>} */ | ||
| export default class SimpleDataNodesIndex extends CollectionIndex { |
There was a problem hiding this comment.
@MiccWan
rename simple to primtive maybe? That is the predominant terminology we use to refer to these types of values
Domiii
reviewed
Dec 19, 2021
| return contexts; | ||
| }, | ||
| [SelectorType.StaticContext]: (selector) => { | ||
| const { applicationId, staticContextId } = selector; |
There was a problem hiding this comment.
@MiccWan Why is this only searching a singular application, and the others search multiple?
There was a problem hiding this comment.
We used this to highlight Contexts of same StaticContext in CallGraph (with a small button in ContextNode). The search algorithm only takes staticContextId into account, which is meaningless for the other applications.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#561 #619