misc fixes #704
Merged
misc fixes #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add `TriggerablePromise` * rename `getNodeByClass` to `getRootByClass`
Domiii
approved these changes
Mar 23, 2022
| if (parent) { | ||
| children = parent.children; | ||
| } | ||
| getChildByClass(clazz, parent) { |
There was a problem hiding this comment.
@MiccWan move to BaseTreeViewNode
| const searchResultNode = this.treeDataProvider.getNodeByClass(GlobalSearchNode); | ||
| await this.treeView.reveal(searchResultNode, { select: false, expand: 1 }); | ||
| const searchResultNode = this.treeDataProvider.getRootByClass(GlobalSearchNode); | ||
| try { |
There was a problem hiding this comment.
@MiccWan if (!this.treeView.visible) { return; }
| @@ -0,0 +1,55 @@ | |||
| import sleep from './sleep'; | |||
|
|
|||
| export default class TriggerablePromise { | |||
There was a problem hiding this comment.
rename to SyncPromise . These are generally used to let outside threads/actors wait for/synchronize against an asynchronous operation.
| contexts = node.group.contexts; | ||
| } | ||
| else { | ||
| throw new Error(`Calling "_handleContextNodeDisposed" with non-ContextNode parameter`); |
There was a problem hiding this comment.
add node to the message, so we (kinda) know what it is?
29 tasks
MiccWan
added a commit
that referenced
this pull request
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#702