Refactor Pathways system
#717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Domiii
reviewed
Apr 10, 2022
| @@ -80,6 +81,7 @@ export default class ExerciseIntroductionView extends WebviewWrapper { | |||
| } | |||
|
|
|||
| export async function showExerciseIntroduction(exercise) { | |||
| showExerciseIntroductionView(exercise); | |||
There was a problem hiding this comment.
@MiccWan
this one does not have emit in its name, but all others do?
Domiii
reviewed
Apr 10, 2022
Domiii
reviewed
Apr 10, 2022
| @@ -78,6 +79,7 @@ export default class ValueTDSimpleNode extends ValueNode { | |||
| } | |||
|
|
|||
| valueRender() { | |||
| emitValueRenderAction(this.value, this.nodeId); | |||
There was a problem hiding this comment.
@MiccWan
Good rule of thumb: either place all events before or place all events after the thing happened. Don't ever switch orders on that. Since we are mostly calling emit afterwards, let's try to make sure, we keep that order
Domiii
reviewed
Apr 10, 2022
| @@ -57,10 +58,12 @@ let graphWebView; | |||
|
|
|||
| export async function showGraphView() { | |||
| await initGraphView(); | |||
| emitCallGraphAction(UserActionType.CallGraphVisibilityChanged, { isShowing: true }); | |||
Domiii
reviewed
Apr 10, 2022
| @@ -55,11 +57,13 @@ export default class PathwaysWebView extends RichWebView { | |||
| let pathwaysWebView; | |||
|
|
|||
| export async function showPathwaysView() { | |||
| emitPathwaysAction(UserActionType.PathwaysVisibilityChanged, { isShowing: true }); | |||
Domiii
approved these changes
Apr 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PathwaysSessionthat allows users to record their own projectsPDPinsidePathwaysSessionPathwaysView#712