Adjust partial language formulas for how much our players love to yap incomprehensibly#764
Adjust partial language formulas for how much our players love to yap incomprehensibly#76400-Steven wants to merge 1 commit intoDopplerShift13:masterfrom
Conversation
|
this won't work properly until an upstream fix arrives to the 1000 most common words, might make a separate testmerge for that |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
2 participants
About The Pull Request
Partial language understanding sets a percentage chance for understanding any given word, which is then weighted up or down based on how common it is in the top 1000 most common. Anything outside of that is weighted as if the 1250th most common word.
Taking into account how people here talk, this means lower percentages are basically unusable, and higher percentages are unintuitively bad.
A previous pr sought to resolve this by capping the formula's minimum translation chance, but it still meant the more common words were often scrambled at lower points.
So in this pr we instead replace the formula entirely, making the chosen percentage the minimum cap and dramatically buffing the chance you understand the top 1000 common words. The latter is supposed to make lower percentages feel like having started flash card studying, by giving you guaranteed translation for the X most common words.
Past 50% you essentially 'know' the top 1000 most common words, and only really roll for uncommon words.
Here's the proposed formula results for a spread of percentages:
10% Understanding:
25% Understanding:
50% Understanding:
75% Understanding:
90% Understanding:
Why It's Good For The Game
See above.
Allows lower partial understandings to still be vaguely usable, and higher to be more consistent. This is better for how much we yap, and I think feels more intuitive than the current formula still making you roll for common words at higher levels.
Testing Evidence
Impossible to test fully due to upstream bug.
Changelog
🆑
balance: Adjusted the partial language formula. The chosen percentage is now the minimum chance you'll understand any given word, while the top 1000 most common words have a dramatically buffed chance. 10% knows the top 200 words guaranteed, 25% the top 500 words, and 50% and above know the full top 1000 most common words.
/:cl: