-
Notifications
You must be signed in to change notification settings - Fork 38
Scripified offline mode #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scripified offline mode #244
Conversation
Also added player creation to script (offline) but it still needs more work.
Removed player UI placeholder objects 3 and 4 players should be created from script now
Added a level setup script for configuring maps based on the game mode type, when they are loaded
Removed unused maps from build/config
Giving this a bit of a test today, but I'd feel more comfortable if somebody with multiple input devices could confirm that nothing has been accidentally broken ( @ErikBehar any chance of getting your thoughts? ). IRC we couldn't have multiple audio listeners, which was why we implemented the Sound Manager. Swing aiming and power adjustment is now slow to match online play (I was hoping we'd go the other way on that). Beyond that, great work! |
@Cheeseness I didn't change aim/power. I did notice that it moves much faster on a gamepad than with a keyboard, which is something we need to balance. |
Tested this on my OUYA with a 2 controller game. There are a few issues: |
There've always been a few positions where the cart can get stuck. If this one is new, do you reckon you could grab a screenshot to better illustrate it?
Has this always been the case? I've never been able to play the game with multiple local players. |
And put the empty 4th cam in bottom-right window. Which colour gets which window seems arbitrary.
Found another controller to test with and there was some leftover code that caused an error; removed that. Also moved the 3/4 player cams because they weren't ordered correctly, it seems. Note: When mapping players to controllers from the lobby screen, the last player (in terms of screens) is always the keyboard.
Tried it out and yes, this is a preexisting thing. FollowPlayerScript is only looking for a mouse or a thumbstick. I also experienced an odd problem where my new controller was registering two players and could control both of them in game. Helpful for testing 4-player games. It stopped doing it when I unplugged/plugged it back in. It probably came up because I was trying to use it while it was installing the drivers. |
Looks good. Thanks for the feedback, people :) |
#235
I put all of the character object information that was in local_full_local_multi into a function in LocalMultiplayerController. Now offline mode can start games in the same map as networked mode and work just as it used to.
netPause, netPlayerRespawn, netWinCollider have offline-game handling and their offline counterparts are obsolete. It also uses the better minimap icons now. Also, lil_patrick is now big_patrick and does the driving animation
I removed those unused maps from the build/level select too.
Issues:
I don't have the controllers to test with 3/4 players.
Only one screen has the audio listener so another player driving makes no noise unless they are close to each other. I think before it had multiple audio listeners but I'm not sure how well that worked. Car noises should be made 2D for splitscreen games imo.
your saved online name gets overwritten as playerX - fixing this when all the scripts are sorted out
all ball markers show on all screens, tagging them should fix this.
Next:
Move player instantiation out of LocalMultiplayerController and into LocalMultiplayerLobbyController so characters carry over between levels.
merge the offline/networked scripts