Adjust ui text and add back buttons #143
Conversation
There was a problem hiding this comment.
Unfortunately a lot of the text is not visible in the setup menu. http://pasteboard.co/WpldBGts.png
|
Ah damn i think i increased the text size right before pushing forgetting
some of it would not appear on lower resolutions.
…On Thu, 27 Apr 2017 at 19:03, Kjell Iwarson ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Unfortunately a lot of the text is not visible in the setup menu.
http://pasteboard.co/WpldBGts.png
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#143 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHxweuloCGQKH3n4GkNdcWsfYnRTrzHTks5r0NhugaJpZM4NKjSC>
.
|
|
I generally use "best fit" with min max values and that solves a lot of issues with font size. If the min value is too high this issue could still appear on lower resolutions. Another option is to change canvas scaling but that affects everything. |
|
The reason I turned off best fit was because all the text was inconsistent.
With a font size of 30 it was legible at the smallest and largest
resolution but then I upped it to 40 without testing properly.
…On Fri, 28 Apr 2017 at 09:13, Stewart Martin ***@***.***> wrote:
I generally use "best fit" with min max values and that solves a lot of
issues with font size. If the min value is too high this issue could still
appear on lower resolutions. Another option is to change canvas scaling but
that affects everything.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#143 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHxweghyWzoyWRchnqb2MS8HWD_XJKNNks5r0Z-pgaJpZM4NKjSC>
.
|
|
Oh right. That makes sense. I've also use content size fitters to force objects to fit my text but that doesn't apply here. |
|
@lightsoda I have reverted the font size back down to its previous size and it is visible at the lowest resolution I can run the game at now. This only affects the setup menu and does not touch the main menu. |
ghost
dismissed
their stale review
Alright, can't test since I'm at work, so I'm dismissing the review for now.
There was a problem hiding this comment.
Ah, I want to merge this. But the instructions aren't visible at all, can we make that element bigger? http://pasteboard.co/d7YFWIEk.png
|
I seem to have the same problem on this branch. Can't see play instructions before match. |
|
I think this still needs changing to work with intervening updates to BaseTable.unity that were needed for the Humble Release. @jctwood are you comfortable reworking things? If not, just sing out :) |
Adds back buttons with a stack of menu panels. Make sure if you add a new menu panel in the script you push it onto the stack. Tested all the menu paths and seems to work perfectly. Also changed the buttons to look slightly less generic.