Lab2 #1108
Closed
Lab2 #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dovgalyuk
requested changes
Nov 21, 2024
LibraryCPPClass/list.cpp
Outdated
| { | ||
| current = current->next(); | ||
| } | ||
| current->set_next(new Item(item->data())); |
There was a problem hiding this comment.
Чем это отличается от кода в конструкторе копирования?
There was a problem hiding this comment.
В операторе присваивания приходится каждый раз проходить весь новый список до конца
Dovgalyuk
requested changes
Nov 22, 2024
LAB2CPPCLASS/lab2.cpp
Outdated
|
|
||
| if (validReg(value[0]) && value.size() == 1) | ||
| { | ||
| cmd.value = value[0]; |
There was a problem hiding this comment.
А если добавится такое же число, как код какой-то буквы.
There was a problem hiding this comment.
Как отработает команда PUSH 65?
|
Проблема осталась. |
Dovgalyuk
reviewed
Dec 20, 2024
LAB2CPPCLASS/lab2.cpp
Outdated
| { | ||
| case typeCommand::PUSH: | ||
| { | ||
| if (cmd.value >= 0 && cmd.value <= 3) |
There was a problem hiding this comment.
А если будет просто команда PUSH 2?
|
Проблема остаётся. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.