Merge pull request #11 from DrFaust92/fixes

Minor fixes post #10
DrFaust92 · Jan 27, 2023 · 9ccd032 · 9ccd032
2 parents c7cc50a + 4c28faf
commit 9ccd032
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 12 deletions.
diff --git a/docs/resources/check.md b/docs/resources/check.md
@@ -60,6 +60,7 @@ The following arguments are supported:
 * `userids` - (Optional) Users to alert.
 * `username` - (Optional) Username to auth with.
 * `verify_certificate` - (Optional) Treat target site as down if an invalid/unverifiable certificate is found. Default value is `true`.
+* `ipv6` - (Optional) Wheter to enable IPV6 on check. Default value is `false`.
 
 ## Attributes Reference
 

diff --git a/pingdom/resource_pingdom_check_test.go b/pingdom/resource_pingdom_check_test.go
@@ -239,7 +239,7 @@ func testAccCheckPingdomCheckDestroy(s *terraform.State) error {
 func testAccResourcePingdomCheckConfig_dns(name string) string {
 	return fmt.Sprintf(`
 resource "pingdom_check" "dns" {
-	name       = "%s"
+	name       = %[1]q
 	host       = "example.com"
 	nameserver = "a.iana-servers.net"
 	expectedip = "2606:2800:220:1:248:1893:25c8:1946"
@@ -251,7 +251,7 @@ resource "pingdom_check" "dns" {
 func testAccResourcePingdomCheckConfig_dns_update(name string) string {
 	return fmt.Sprintf(`
 resource "pingdom_check" "dns" {
-	name       = "%s"
+	name       = %[1]q
 	host       = "example.org"
 	nameserver = "b.iana-servers.net"
 	expectedip = "93.184.216.34"
@@ -263,7 +263,7 @@ resource "pingdom_check" "dns" {
 func testAccResourcePingdomCheckConfig_ping(name string) string {
 	return fmt.Sprintf(`
 resource "pingdom_check" "ping" {
-	name = "%s"
+	name = %[1]q
 	host = "www.example.com"
 	type = "ping"
 }
@@ -273,7 +273,7 @@ resource "pingdom_check" "ping" {
 func testAccResourcePingdomCheckConfig_ping_update(name string) string {
 	return fmt.Sprintf(`
 resource "pingdom_check" "ping" {
-	name = "%s"
+	name = %[1]q
 	host = "www.example.org"
 	type = "ping"
 }
@@ -283,7 +283,7 @@ resource "pingdom_check" "ping" {
 func testAccResourcePingdomCheckConfig_tcp(name string) string {
 	return fmt.Sprintf(`
 resource "pingdom_check" "tcp" {
-	name = "%s"
+	name = %[1]q
 	host = "www.example.com"
 	port = 80
 	type = "tcp"
@@ -294,7 +294,7 @@ resource "pingdom_check" "tcp" {
 func testAccResourcePingdomCheckConfig_tcp_update(name string) string {
 	return fmt.Sprintf(`
 resource "pingdom_check" "tcp" {
-	name = "%s"
+	name = %[1]q
 	host = "www.example.org"
 	port = 443
 	type = "tcp"
@@ -305,7 +305,7 @@ resource "pingdom_check" "tcp" {
 func testAccResourcePingdomCheckConfig_http(name string) string {
 	return fmt.Sprintf(`
 resource "pingdom_check" "http" {
-	name                 = "%s"
+	name                 = %[1]q
 	host                 = "www.example.com"
 	type                 = "http"
 	ssl_down_days_before = 10
@@ -316,7 +316,7 @@ resource "pingdom_check" "http" {
 func testAccResourcePingdomCheckConfig_http_update(name string) string {
 	return fmt.Sprintf(`
 resource "pingdom_contact" "test" {
-	name = "%s"
+	name = %[1]q
 	sms_notification {
 		number   = "66666666"
 		severity = "HIGH"
@@ -328,12 +328,12 @@ resource "pingdom_contact" "test" {
 }
 
 resource "pingdom_team" "test" {
-	name = "%s"
+	name = %[1]q
 	member_ids = [pingdom_contact.test.id]
 }
 
 resource "pingdom_check" "http" {
-	name                     = "%s"
+	name                     = %[1]q
 	host                     = "www.example.org"
 	type                     = "http"
 	resolution               = 15
@@ -358,7 +358,7 @@ resource "pingdom_check" "http" {
 	requestheaders = {
 		X-Test-Data = "test"
 	}
-	ipv6                     = false
+	ipv6                     = true
 }
-`, name, name, name)
+`, name)
 }