Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make MapVariableStorage concurrent-safe #8

Merged
merged 1 commit into from
May 14, 2023
Merged

Make MapVariableStorage concurrent-safe #8

merged 1 commit into from
May 14, 2023

Conversation

DrJosh9000
Copy link
Owner

The bare map wrapper is now a struct with a map and a mutex. The type can no longer be constructed with make, so there is also NewMapVariableStorage.

See #6

kalexmills
kalexmills approved these changes May 8, 2023
View reviewed changes
Copy link
Collaborator

@kalexmills kalexmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this! Closes #6.

@DrJosh9000 DrJosh9000 marked this pull request as ready for review May 14, 2023 07:18
@DrJosh9000 DrJosh9000 merged commit 72f8469 into main May 14, 2023
@DrJosh9000 DrJosh9000 deleted the sync-map branch May 14, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalexmills kalexmills kalexmills approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DrJosh9000 @kalexmills