Pull request #123
Merged
Pull request #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The `select!` macro uses the `biased` option so clauses are evaluated in order. The time-of-day and solar futures are placed first because they happen infrequently and we don't want high-speed devices starving these channels. - For the solar channel, we now do more error reporting. This helped uncover a bug (fixed in a different commit.) - Rather than returning Futures that return None, we now use the never resolving future.
This tests a logic block that only uses solar parameters for inputs.
When this channel was only 1 deep, logic blocks would occasionally get a Lagging error which would cause them to panic. The logic block code was improved, but the channel was enlarged so these error wouldn't occur under normal circumstances.
A section was placed in a nested scope. This allowed us to remove two calls to `std::mem::drop()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request is the result of a logic block panicking. It occurred in a logic block that had no inputs and only used solar parameters. This pull request contains some code "improvements" that didn't fix the bug, but which I think are better than the original code.