Refactoring pull request #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I bumped `drmem-api` to v0.5.0, but didn't update any of the packages to it as well.
This will allow us to better partitions types when we enhance the driver API.
The value associated with this variant is now an `Arc<str>`. Since readings are sent through a broadcast channel, each value gets cloned when delivered to a receiver. Cloning an `Arc` is much cheaper than cloning the entire string.
Up to this point, when a device driver registered a read-only device, it was given a `Sender<>` handle (to report new values returned by the device) and the possible previous value of the device. When the driver API went to the 3-phase lifecycle, the previous value was missplaced (it couldn't be used during registration.) With this commit, a new type is defined: `ReadOnlyDevice<T>`. It not only lets the driver report new values using native types, but it also hangs on to the previous value. This way the previous value can be queried during the operational phase of the driver.
Create a new type which encapsulates the tuple that described the state of a writable device. Move both `ReadOnlyDevice` and `ReadWriteDevice` into their own modules.
The reason for the previous value was so, when restarting DrMem, devices could be set back to their previous setting. Read-only devices get their value from querying their hardware. You don't restore a read-only device.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains some refactoring:
Cargo.tomlfiles need to refer to "0.5".device::Value::Strvariant contain anArc<str>instead of aString. This layout is much more efficient in that the string doesn't have to be copied for every client that reads a device that returns a string.ReadOnlyDeviceandReadWriteDevice, respectively.