Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComputerCraft and OpenComputers II integration #1785

Open
wants to merge 8 commits into
base: 1.20
Choose a base branch
from

Conversation

igentuman
Copy link

No description provided.

@igentuman igentuman changed the title Fix for ComputerCraft integration ComputerCraft and OpenComputers II integration Jul 21, 2024
@@ -55,13 +55,27 @@ configurations {
}

repositories {
flatDir { dirs 'libs' }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be here.

mavenLocal()
maven { url = "https://maven.covers1624.net/" }
maven { url = "https://dvs1.progwml6.com/files/maven" }
maven { url = "https://maven.cil.li/" }
maven { url = "https://maven.theillusivec4.top/" }
maven { url = "https://squiddev.cc/maven/" }
maven { url = "https://maven.blamejared.com/" }
maven {
url "https://maven.architectury.dev"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, I would like to avoid having an arch dep. You should be able to just dep on the OC2 api, which should not require an arch dep.

@brandon3055
Copy link
Member

I went with SquidDev's PR because it was a much simpler / cleaner solution.
Though, it would still be nice to support oc2 if you would like to re-work your PR a little.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants