only subscribe if actions are available (#403)

<!--- Provide a general summary of your changes in the title above -->
<!--- Link the corresponding issues after you created the pull request
-->

## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)

## Checklist:
<!--- Go over all the following points, and put an `x` in all the boxes
that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
- [x] I have updated the [changelog](../CHANGELOG.md) accordingly.
- [x] I have added tests to cover my changes.

.github/workflows/build.yml

@@ -18,10 +18,10 @@ jobs:
 
     steps:
       - name: Check out Git repository
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Set up Python
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
           python-version: "3.12"
 
@@ -43,7 +43,7 @@ jobs:
           echo TARGZ=$(echo dist/*.tar.gz) >> $GITHUB_OUTPUT
 
       - name: Archive package
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: distributions
           path: dist
@@ -55,22 +55,22 @@ jobs:
     strategy:
       matrix:
         python-version: [ "3.7", "3.8" , "3.9", "3.10", "3.11", "3.12" ]
-        os: [ ubuntu-latest, windows-latest ]
+        os: [ ubuntu-22.04, windows-latest ]
         distribution: [ "${{ needs.build.outputs.WHL }}",
                         "${{ needs.build.outputs.TARGZ }}" ]
     runs-on: ${{ matrix.os }}
 
     steps:
       - name: Check out Git repository
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Set up Python
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
           python-version: ${{ matrix.python-version }}
 
       - name: Download Artifact
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: distributions
           path: dist
@@ -79,7 +79,7 @@ jobs:
         run: pip install ${{ matrix.distribution }}[test]
 
       - name: Detect suffix on ubuntu
-        if: ${{ matrix.os == 'ubuntu-latest' }}
+        if: ${{ matrix.os == 'ubuntu-22.04' }}
         run: |
           echo SUFFIX=$(python -c "import pathlib;p=pathlib.Path('${{ matrix.distribution }}');print('whl') if p.suffix=='.whl' else print('tar_gz')") >> $GITHUB_ENV
 
@@ -99,18 +99,18 @@ jobs:
           --log-file pytest_${{ matrix.os }}_py${{ matrix.python-version }}_${{ env.SUFFIX }}.log
 
       - name: Archive test result
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         if: success() || failure()  # upload artifacts also if test stage failed
         with:
-          name: unittest_reports
+          name: unittest_report_${{ matrix.os }}_py${{ matrix.python-version }}_${{ env.SUFFIX }}.html
           path: pytest_reports/unittest_report_${{ matrix.os }}_py${{ matrix.python-version }}_${{ env.SUFFIX }}.html
           retention-days: 5
 
       - name: Archive test log
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         if: success() || failure()  # upload artifacts also if test stage failed
         with:
-          name: pytest_logs
+          name: pytest_${{ matrix.os }}_py${{ matrix.python-version }}_${{ env.SUFFIX }}.log
           path: pytest_${{ matrix.os }}_py${{ matrix.python-version }}_${{ env.SUFFIX }}.log
           retention-days: 5
 

.github/workflows/publish.yml

@@ -20,7 +20,7 @@ jobs:
 
     steps:
       - name: Download Artifact
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: distributions
           path: dist/
@@ -46,19 +46,20 @@ jobs:
 
     steps:
       - name: Check out Git repository
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Download Build
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: distributions
           path: dist
 
       - name: Download Unittest report
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
-          name: unittest_reports
+          pattern: unittest_report_*
           path: pytest_reports/
+          merge-multiple: true
 
       - name: Zip unittest reports
         uses: vimtor/[email protected]

CHANGELOG.md

@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Fixed
 - accessing a multikey may lead to IndexError [#359](https://github.com/Draegerwerk/sdc11073/issues/359)
 - fixed a bug where `log_prefix` can only be a string [#393](https://github.com/Draegerwerk/sdc11073/issues/393)
+- only send subscribe request if there are actions to subscribe to [#402](https://github.com/Draegerwerk/sdc11073/issues/402)
 
 ## [1.3.2] - 2024-03-18
 

src/sdc11073/sdcclient/sdcclientimpl.py

@@ -408,6 +408,9 @@ def startAll(self, notSubscribedActions=None, subscriptionsCheckInterval=None, a
                 subscribe_actions = set(available_actions) - notSubscribedActionsSet
                 if not subscribe_periodic_reports:
                     subscribe_actions -= set(periodic_actions)
+                if not subscribe_actions:
+                    self._logger.warning('startAll: no actions to subscribe for service_id = {}', service_id)
+                    continue
                 try:
                     self._subscribe(dpwsHosted, subscribe_actions,
                                     self._onAnyStateEventReport)

tests/test_client_device.py

@@ -22,6 +22,7 @@
 from sdc11073 import namespaces
 from sdc11073 import observableproperties
 from sdc11073 import pmtypes
+from sdc11073.definitions_sdc import SDC_v1_Definitions
 from sdc11073.location import SdcLocation
 from sdc11073.mdib import ClientMdibContainer
 from sdc11073.mdib import clientmdib
@@ -1756,6 +1757,13 @@ def test_invalid_request(self):
             else:
                 self.assertTrue(False, 'HTTPReturnCodeError not raised')
 
+    def test_subscribe_not_all(self):
+        self.sdcClient_Final.stopAll()
+        with mock.patch.object(self.sdcClient_Final._logger, 'warning') as mock_logger:
+            self.sdcClient_Final.startAll(notSubscribedActions=[SDC_v1_Definitions.Actions.OperationInvokedReport])
+        self.assertFalse(self.sdcClient_Final.all_subscribed)
+        mock_logger.assert_any_call('startAll: no actions to subscribe for service_id = {}', 'SetService')
+
 
 class Test_DeviceCommonHttpServer(unittest.TestCase):
     @classmethod