Skip to content

Xml mdib#401

Merged
leon1995 merged 56 commits intoDraegerwerk:masterfrom
deichmab-draeger:xml_mdib
Feb 14, 2025
Merged

Xml mdib#401
leon1995 merged 56 commits intoDraegerwerk:masterfrom
deichmab-draeger:xml_mdib

Conversation

@deichmab-draeger
Copy link
Copy Markdown
Member

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have updated the changelog accordingly.
  • I have added tests to cover my changes.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 90.10074% with 226 lines in your changes missing coverage. Please review.

Project coverage is 90.82%. Comparing base (5291b9e) to head (160ed63).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/sdc11073/mdib/transactions.py 66.15% 44 Missing ⚠️
src/sdc11073/entity_mdib/entity_consumermdib.py 91.87% 36 Missing ⚠️
src/sdc11073/mdib/mdibbase.py 67.74% 30 Missing ⚠️
src/sdc11073/entity_mdib/entity_transactions.py 93.62% 25 Missing ⚠️
src/sdc11073/entity_mdib/entity_providermdib.py 92.67% 20 Missing ⚠️
src/sdc11073/roles/clockprovider.py 56.25% 14 Missing ⚠️
...rc/sdc11073/entity_mdib/entity_providermdibxtra.py 94.07% 8 Missing ⚠️
src/sdc11073/entity_mdib/entities.py 97.41% 6 Missing ⚠️
src/sdc11073/mdib/descriptorcontainers.py 45.45% 6 Missing ⚠️
src/sdc11073/roles/alarmprovider.py 96.47% 6 Missing ⚠️
... and 13 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #401      +/-   ##
==========================================
- Coverage   90.88%   90.82%   -0.06%     
==========================================
  Files         116      125       +9     
  Lines       12963    14700    +1737     
==========================================
+ Hits        11781    13352    +1571     
- Misses       1182     1348     +166     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread src/sdc11073/entity_mdib/entities.py
Comment thread src/sdc11073/entity_mdib/entities.py
Comment thread src/sdc11073/entity_mdib/entities.py
Comment thread src/sdc11073/entity_mdib/entities.py Outdated
Comment thread src/sdc11073/entity_mdib/entity_consumermdib.py Outdated
Comment thread src/sdc11073/entity_mdib/entity_consumermdib.py Outdated
Comment thread src/sdc11073/entity_mdib/entity_consumermdib.py Outdated
Comment thread src/sdc11073/entity_mdib/entity_consumermdib.py
Comment thread src/sdc11073/entity_mdib/entity_consumermdib.py Outdated
Copy link
Copy Markdown
Member

@leon1995 leon1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because of time constraints, I had to do without a lot of things

@leon1995 leon1995 merged commit 5196779 into Draegerwerk:master Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants