Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GridTrading] add test and log #1426

Merged
merged 1 commit into from
Jan 26, 2025
Merged

[GridTrading] add test and log #1426

merged 1 commit into from
Jan 26, 2025

Conversation

GuillaumeDSM
Copy link
Member

No description provided.

@GuillaumeDSM GuillaumeDSM requested a review from Herklos January 26, 2025 21:16
@GuillaumeDSM GuillaumeDSM self-assigned this Jan 26, 2025
@GuillaumeDSM GuillaumeDSM enabled auto-merge (rebase) January 26, 2025 21:16
@@ -440,7 +440,7 @@ async def _generate_staggered_orders(self, current_price, ignore_available_funds
highest_buy = current_price
lowest_sell = current_price
origin_created_buy_orders_count, origin_created_sell_orders_count = self._get_origin_orders_count(
sorted_orders, recently_closed_trades
recently_closed_trades, sorted_orders
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it has not consequence but i prefer fixing it ^^

@@ -911,6 +911,79 @@ async def test_start_after_offline_x_filled_and_price_back_should_buy_to_recreat
_check_created_orders(producer, trading_api.get_open_orders(exchange_manager), 200)


async def test_start_after_offline_x_filled_and_missing_should_recreate_sell():
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GuillaumeDSM GuillaumeDSM merged commit e37bf67 into dev Jan 26, 2025
5 checks passed
@GuillaumeDSM GuillaumeDSM deleted the grid branch January 26, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants