Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth #2822

Merged
merged 2 commits into from
Dec 7, 2024
Merged

Auth #2822

merged 2 commits into from
Dec 7, 2024

Conversation

GuillaumeDSM
Copy link
Member

@GuillaumeDSM GuillaumeDSM self-assigned this Dec 7, 2024
@GuillaumeDSM GuillaumeDSM requested a review from Herklos as a code owner December 7, 2024 15:11
Herklos
Herklos approved these changes Dec 7, 2024
View reviewed changes
Copy link
Member

@Herklos Herklos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 👍

additional_tests/exchanges_tests/abstract_authenticated_exchange_tester.py
assert portfolio == {}
else:
assert portfolio
assert rest_exchange_data["calls"][-1][0][0] != latest_calls[-1][0][0] # assert latest call's url changed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GuillaumeDSM GuillaumeDSM merged commit 88debc9 into dev Dec 7, 2024
14 checks passed
@GuillaumeDSM GuillaumeDSM deleted the auth branch December 7, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Herklos Herklos Herklos approved these changes

Assignees

@GuillaumeDSM GuillaumeDSM

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuillaumeDSM @Herklos