[DSLTradingMode] add and migrate TV trading mode for DSL by GuillaumeDSM · Pull Request #3277 · Drakkar-Software/OctoBot

GuillaumeDSM · 2026-02-27T18:36:57Z

No description provided.

Herklos

Great implementation 💯

Herklos · 2026-03-04T08:32:36Z

packages/commons/octobot_commons/dsl_interpreter/interpreter.py

                operands = [self._visit_node(operand) for operand in node.elts]
                return operator_class(*operands)

+        if isinstance(node, ast.Dict):


Herklos · 2026-03-04T08:32:44Z

packages/commons/octobot_commons/dsl_interpreter/interpreter.py

                step = self._visit_node(node.step)
                return operator_class(lower, upper, step)

+        if isinstance(node, ast.Raise):


Herklos · 2026-03-04T08:33:42Z

packages/commons/octobot_commons/dsl_interpreter/interpreter_dependency.py

+@dataclasses.dataclass
+class SymbolDependency(InterpreterDependency):
+    symbol: str
+    time_frame: typing.Optional[str] = None


It seems a bit specific, is it the right place for this dataclass?

right, i'll move it to trading

Herklos · 2026-03-04T08:35:08Z

packages/commons/octobot_commons/dsl_interpreter/parameters_util.py

+    return repr(value)
+
+
+def resove_operator_params(


Herklos · 2026-03-04T08:35:54Z

packages/commons/tests/dsl_interpreter/test_parameters_util.py

+        operator_class.get_parameters.return_value = [param_a]
+        operator_class.get_name.return_value = "test_op"
+        operator_class.get_parameters_description.return_value = "1: a [int] - first"
+        with pytest.raises(commons_errors.InvalidParametersError, match="test_op supports up to 1 parameters"):


Herklos · 2026-03-04T08:44:20Z

...les/Meta/DSL_operators/exchange_operators/exchange_private_data_operators/order_operators.py

+    input_quantity_ratio: decimal.Decimal
+
+
+class _OrderFactory:


There are 2 OrderFactory one for create_order operators and one for order operators?

Herklos · 2026-03-04T08:46:42Z

packages/tentacles/Trading/Mode/dsl_trading_mode/dsl_trading.py

+        return True
+
+
+class DSLTradingMode(trading_modes.AbstractTradingMode):


Can this trading mode be selected by a user with the profile building UI? If so what happens if the user choose to use it?

it will execute the configured DSL script when evaluator will trigger the strategy

Herklos · 2026-03-04T08:48:13Z

...ng/Mode/trading_view_signals_trading_mode/tests/test_tradingview_signal_to_dsl_translator.py

+    )
+
+
+class TestMapOtherParamsToDsl:


Great tests!

Herklos · 2026-03-04T08:50:31Z

packages/trading/octobot_trading/modes/channel/abstract_mode_consumer.py

-        chained_order = personal_data.create_order_instance(
-            trader=self.exchange_manager.trader,
-            order_type=order_type,
-            symbol=main_order.symbol,
-            current_price=price,
-            quantity=quantity or main_order.origin_quantity,
-            price=price,
-            side=side,
-            associated_entry_id=main_order.order_id,
-            reduce_only=reduce_only,
+        return await personal_data.create_and_register_chained_order_on_base_order(
+            main_order,
+            price,
+            order_type,
+            side,
+            quantity=quantity,
+            allow_bundling=allow_bundling,
            tag=tag,
+            reduce_only=reduce_only,
+            update_with_triggering_order_fees=update_with_triggering_order_fees


Herklos · 2026-03-04T08:50:59Z

packages/trading/octobot_trading/modes/script_keywords/context_management.py

    return get_full_context(trading_mode, None, None, symbol, None, None, None, None, None, init_call=init_call)


+def get_base_context_from_exchange_manager(exchange_manager, symbol):


Is it used somewhere?

yes, in create_order_operators where a trading mode might not be available

GuillaumeDSM · 2026-03-04T17:35:21Z

PR is up !

Herklos

👍

GuillaumeDSM self-assigned this Feb 27, 2026

GuillaumeDSM force-pushed the dsl_TM branch 3 times, most recently from 2e62b7d to ad4f484 Compare March 3, 2026 20:11

GuillaumeDSM marked this pull request as ready for review March 3, 2026 20:13

GuillaumeDSM requested a review from Herklos as a code owner March 3, 2026 20:13

GuillaumeDSM changed the title ~~[DSLTradingMode] init~~ [DSLTradingMode] add and migrate TV trading mode for DSL Mar 3, 2026

GuillaumeDSM force-pushed the dsl_TM branch 2 times, most recently from a8d6a5d to 9a979d5 Compare March 4, 2026 08:50

Herklos reviewed Mar 4, 2026

View reviewed changes

GuillaumeDSM force-pushed the dsl_TM branch 2 times, most recently from e4a726e to 78cf051 Compare March 4, 2026 17:32

Herklos approved these changes Mar 4, 2026

View reviewed changes

GuillaumeDSM force-pushed the dsl_TM branch from 78cf051 to 44e2b3d Compare March 4, 2026 21:38

GuillaumeDSM added 2 commits March 5, 2026 21:09

[DSLTradingMode] init

1404048

[TradingView] migrate to DSL implementation

9da8c85

GuillaumeDSM force-pushed the dsl_TM branch from 44e2b3d to 9da8c85 Compare March 5, 2026 20:09

		return True


		class DSLTradingMode(trading_modes.AbstractTradingMode):

		return get_full_context(trading_mode, None, None, symbol, None, None, None, None, None, init_call=init_call)


		def get_base_context_from_exchange_manager(exchange_manager, symbol):

Uh oh!

Conversation

GuillaumeDSM commented Feb 27, 2026

Uh oh!

Herklos left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GuillaumeDSM commented Mar 4, 2026

Uh oh!

Herklos left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants