Skip to content

Improve FishingRodPropertyMixin compatibility #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tranquillity-codes wants to merge 1 commit into
base: 1.20.1
Choose a base branch
from
Open

Improve FishingRodPropertyMixin compatibility #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/main/java/draylar/gofish/mixin/FishingRodPropertyMixin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
import org.spongepowered.asm.mixin.Unique;
import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Inject;
import org.spongepowered.asm.mixin.injection.Redirect;
import org.spongepowered.asm.mixin.injection.ModifyArg;
import org.spongepowered.asm.mixin.injection.callback.CallbackInfoReturnable;

import java.util.ArrayList;
Expand All @@ -38,13 +38,13 @@ private void storeContext(World world, PlayerEntity user, Hand hand, CallbackInf
this.player = user;
}

@Redirect(method = "use", at = @At(value = "INVOKE", target = "Lnet/minecraft/world/World;spawnEntity(Lnet/minecraft/entity/Entity;)Z"))
private boolean modifyBobber(World world, Entity entity) {
@ModifyArg(method = "use", at = @At(value = "INVOKE", target = "Lnet/minecraft/world/World;spawnEntity(Lnet/minecraft/entity/Entity;)Z"))
private Entity modifyBobber(Entity entity) {
World world = entity.getWorld();
if(entity instanceof FishingBobberEntity bobber) {
modifyBobber(world, bobber);
}

return world.spawnEntity(entity);
return entity;
}

@Unique
Expand Down