Fix C++20 compatibility after libcanon submodule update #47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The libcanon submodule update to C++20 changed canonical form ordering due to
std::unordered_mapiteration differences between C++14 and C++20. This broke tests expecting specific index orderings (e.g.,m[i,j]vsm[j,i]), though the forms remain mathematically equivalent.Changes
Build configuration
CMakeLists.txtto require C++20 standardCore logic (
drudge/fock.py)write_in_qpto accept equivalent canonical forms for matrix elements with identical creation/annihilation ordersTest expectations
term_test.py,free_algebra_test.py,genmb_test.py,parthole_test.pyExample
Before C++20, canonicalization consistently produced:
After C++20, may produce:
Both forms are mathematically identical due to summation commutativity and symmetry properties.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.