[WIP - To discuss, DO NOT merge] Add STM boards #77
Conversation
…'t get shrink because of the indent function
- Display STM board only when a checkbox is checked
…hortnames was too vague - Change the caption label of the checkbox used to enable STM boards
…onfigModel instead of parsing the DOM
e.g : Super8Pro cannot be used for both STM32H723BoardType and STM32H743BoardType
* Add doctrings
Remove stm.blPorts : Use ports.pwm instead Change stm.serialAmount type to number
…for EJS syntax highlighting
.vscode/launch.json
Outdated
There was a problem hiding this comment.
.vscode files are ignored by .gitignore. Please remove this file from git.
There was a problem hiding this comment.
Why this? I see no benefit.
There was a problem hiding this comment.
It is to hide the STM boards when the disclaimer checkbox is unchecked. This is related to that section.
| @@ -43,10 +44,14 @@ export interface BoardDescriptor extends BaseBoardDescriptor { | |||
| supportsBME280: boolean; | |||
| } | |||
|
|
|||
| export type BoardTypes = BoardType | STMBoardTypes | |||
There was a problem hiding this comment.
Is it really necessary to export both?
There was a problem hiding this comment.
For STMBoardTypes, I added a property stm to store the info needed and related to each board.
The easiest way I found was to add these boards to the Boards descriptor and by defining BoardTypes as this.
I would have prefered to have an independant descriptor record for the STMboards (for example defined in store/STMBoards.ts as it would be easier to maintain) but I didn't found an easy way to do this (and without needing to modify many files ...).
That's actually why I created this PR : to discuss about this solution.
| @@ -230,6 +230,7 @@ defaultTemplate.configTool.assignPort("out0", ConfigPortFunction.heater, 0); // | |||
| defaultTemplate.configTool.assignPort("out1", ConfigPortFunction.heater, 1); // Nozzle heater | |||
| defaultTemplate.configTool.assignPort("out3", ConfigPortFunction.fan, 0); // Nozzle fan | |||
| defaultTemplate.configTool.assignPort("out4", ConfigPortFunction.fan, 1); // Nozzle thermostatic fan | |||
| defaultTemplate.configTool.enableSTMBoards = true; | |||
There was a problem hiding this comment.
The official ConfigTool cannot enable STM boards by default unless a disclaimer is confirmed stating that your boards are third-party boards and not developed or maintained by Duet3D. This disclaimer should show up when you click on the checkbox to enable STM boards.
There was a problem hiding this comment.
Yes I know but this PR is to discuss about the way I expanded the Boards Record descriptor.
I just forgot to remove this before the PR and I defined this default value to not have to check the checkbox each time I want to test something.
This will be indeed removed on the final PR.
This PR is not intended to be merged.
LoicGRENON
changed the title
Here is a work in progress to add the STM boards supported by TeamGloomy to the ConfigTool.
I first wanted to separate these boards from the Duet ones by adding them into store/STMBoards.ts instead of store/Boards.ts
but I couldn't find an easy way to expand the Boards Record descriptor without having to change a lot of files ...
What are your thoughts about this ?