tp to last position if we receive an OOB position#151
Draft
MarkJoaquim wants to merge 2 commits intomasterfrom
Draft
tp to last position if we receive an OOB position#151MarkJoaquim wants to merge 2 commits intomasterfrom
MarkJoaquim wants to merge 2 commits intomasterfrom
Conversation
Comment on lines
-53
to
-77
| match &patchwork.maps[anchor.map_index].peer_connection { | ||
| Some(_) => match msg.packet { | ||
| Packet::Unknown => {} | ||
| _ => { | ||
| trace!( | ||
| "Routing packet from conn_id {:?} through anchor", | ||
| msg.conn_id | ||
| ); | ||
| player_state.anchored_move_and_look( | ||
| msg.conn_id, | ||
| extract_player_position((&msg.packet).clone()), | ||
| None, | ||
| ); | ||
| messenger.send_packet(anchor.conn_id.unwrap(), msg.packet.clone()); | ||
| } | ||
| }, | ||
| None => { | ||
| trace!("Routing packet from conn_id {:?} locally", msg.conn_id); | ||
| gameplay_router::route_packet( | ||
| msg.packet.clone(), | ||
| msg.conn_id, | ||
| player_state.clone(), | ||
| sender.clone(), | ||
| ); | ||
| } |
Owner
There was a problem hiding this comment.
Why delete this? Won't all non-positional packets get ignored now?
Collaborator
Author
There was a problem hiding this comment.
Ah whoops, I was just trying to avoid handling position packets that are out of bounds so I moved it to after we check the map position but you're right that this will ignore non position packets...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: Enforce Map Borders #143
Why: see issue
What: when patchwork receives a position for which there is no map, we call playerstate to send the last position we have for the player
Checks