Skip to content

fix: apply PDF flip transforms on export - #629

Open
nyxsky404 wants to merge 2 commits into
Durgeshwar-AI:mainfrom
nyxsky404:fix/604-apply-pdf-flips
Open

fix: apply PDF flip transforms on export#629
nyxsky404 wants to merge 2 commits into
Durgeshwar-AI:mainfrom
nyxsky404:fix/604-apply-pdf-flips

Conversation

@nyxsky404

Copy link
Copy Markdown
Contributor

Pull Request

Issue Reference

Closes #604


Summary

  • mirror page content for horizontal/vertical flips during export
  • keep rotation + selected-page scope behavior
  • add regression coverage for flip/rotation export paths

Screenshots (if applicable)

NA


Checklist

  • My code follows the project's coding conventions
  • I have tested all impacted features
  • I have updated or added necessary documentation

Related Issues / PRs

NA


Open Source Program Participation

Program Name: GSSoC


Additional Notes

Preview already showed flips; export only applied rotation before this. Focused Vitest checks, typecheck, and production build pass.

Co-authored-by: Cursor <cursoragent@cursor.com>
@vercel

vercel Bot commented Aug 6, 2026

Copy link
Copy Markdown

@nyxsky404 is attempting to deploy a commit to the Durgeshwar's projects Team on Vercel.

A member of the Team first needs to authorize it.

Resolve conflicts by keeping flip-aware export via buildTransformedPdf
while preserving all non-removed source pages with buildExportPages.

Co-authored-by: Cursor <cursoragent@cursor.com>
@nyxsky404

Copy link
Copy Markdown
Contributor Author

@Durgeshwar-AI Merge conflicts with main are resolved (flip-aware export kept, and upstream page-preservation via buildExportPages retained).

The remaining backend CI failure (test_add_watermark_text_success / test_add_watermark_image_successValueError: not enough values to unpack in blueprints/watermark.py) is already present on upstream main, and is unrelated to this PR. The Vercel check is also failing on a team authorization URL, not on this PR’s code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] PDF Rotate & Flip ignores horizontal and vertical flips during export

1 participant