Open
Conversation
Owner
|
As discussed on discord, i'd prefer to keep the connect params so the function remains context agnostic. Also, i'd prefer to keep the reconnect attempt process so we're sure the app connects to OBS even if OBS is started after. async function connect(port:string, pass:string):Promise<void> {
return new Promise((resove, reject)=> {
try { /*...*/ }
catch(error) {
//....
return;
}
//...
resolve();
})
}Thank you for your feedback :) ! |
665b0a6 to
699f4f1
Compare
91b7ba7 to
6888aa4
Compare
f96cd21 to
9b593b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed example code where the connect() function takes arguments but are not set in the call.
Also, removed the setTimeout() in case of connection error, since it won't return anyway.