Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: created system-only nbody demo for issue #65 #94

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

feat: created system-only nbody demo for issue #65 #94

wants to merge 13 commits into from

Conversation

Vigithai
Copy link
Collaborator

@Vigithai Vigithai commented Jul 3, 2024

Resolves #65

carynbear
carynbear requested changes Jul 22, 2024
View reviewed changes
demos/algorithms/cnn_demo.ipynb
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should not change this file. Please reset your changes.

demos/systems/dnn_nbody_demo.ipynb Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File is incorrectly named, should be nbody_demo.ipynb

My Name added 10 commits July 22, 2024 16:41
created demo for cnn from dmd_demo as template
0f436d2
implemented a system-only demo for Nbody system
4188c30
Merge branch 'feat/system-nbody-demo' of https://github.com/vigithai/…
93c0f26 
…dynadojo into feat/system-nbody-demo

updating PR
resolved pull request issues: correctly renamed nbody_demo, and resto…
b3b9af8 
…red cnn_demo
created demo for cnn from dmd_demo as template
9aed8bc
implemented a system-only demo for Nbody system
681164a
resolved pull request issues: correctly renamed nbody_demo, and resto…
27701a6 
…red cnn_demo
resolved pull request issues pt2; deleting old dnn_nbody_demo.ipynb f…
026ee57 
…ile that was incorrectly named
Merge branch 'feat/system-nbody-demo' of https://github.com/vigithai/…
9db3eda 
…dynadojo into feat/system-nbody-demo
resolved pull request issues; deleting old dnn_nbody_demo.ipynb file …
3329094 
…that was incorrectly named
@carynbear
Copy link
Collaborator

carynbear commented Jul 26, 2024 •
edited
Loading

@Vigithai

Oops I don't think you fixed the issue. What I would do:

  1. git log to find the commit with the
  2. Switch to main
  3. Pull from upstream/main
  4. Make a new branch off of main
  5. git cherry-pick f7e2e26c69022d11838f244174d225635a69b190 to apply the commit for nbody
  6. Rename nbody
  7. Push, make new pull request and close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carynbear carynbear carynbear requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

demo/feat: missing system/n-body demo
2 participants
@Vigithai @carynbear