Skip to content

DYN-8088 DSCore.List.Flatten does not work in PythonNet3 #16761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ivaylo-matov wants to merge 3 commits into
base: master
Choose a base branch
from
+49 −10
Open

DYN-8088 DSCore.List.Flatten does not work in PythonNet3 #16761

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f136f86
new python test
ivaylo-matov Dec 3, 2025
55a1ceb
copilot comments addressed
ivaylo-matov Dec 3, 2025
34890fe
pythonnet3 version bump
ivaylo-matov Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 30 additions & 7 deletions test/Libraries/DynamoPythonTests/PythonEvalTestsWithLibraries.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,7 @@ from FFITarget import DummyMath
}
}

/// <summary>
/// PythonNet3 vs DesignScript list interop issue:
/// DSCore list ops expect DS lists; PythonNet passes .NET lists, causing wrong overloads/comparers.
/// Quarantined until parity fix.
/// </summary>
[Test]
[Category("Failure")]
[Category("TechDebt")]
public void TestListDecoding()
{
string code = @"
Expand Down Expand Up @@ -344,6 +337,36 @@ import DSCore
}
}

[Test]
public void TryDecode_ConvertsNestedPythonListsToClrLists()
Comment on lines +340 to +341
Copy link

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a test case that verifies the behavior when List.Flatten is called with different depth parameters (e.g., 0, 1) to ensure the fix handles various flattening levels correctly, not just the complete flatten with -1.

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

@ivaylo-matov ivaylo-matov Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now addressed

{
string code = @"
import clr
clr.AddReference('DSCoreNodes')
from DSCore import List

data = [[1, 2, 3], [4, 5, 6]]
OUT = data, List.Flatten(data, -1)
";
var empty = new ArrayList();
Copy link

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The variable name 'empty' is misleading since it's used as an argument to pythonEvaluator but doesn't reflect its purpose. Consider renaming to something like 'emptyInputs' or 'emptyParameters' to clarify its role in the evaluator call.

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

@ivaylo-matov ivaylo-matov Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now addressed

var expected = new ArrayList
{
new ArrayList
{
new ArrayList { 1, 2, 3 },
new ArrayList { 4, 5, 6 }
},
new ArrayList { 1, 2, 3, 4, 5, 6 }
};

foreach (var pythonEvaluator in Evaluators)
{
var result = pythonEvaluator(code, empty, empty);
Assert.That(result, Is.InstanceOf<IEnumerable>());
CollectionAssert.AreEqual(expected, result as IEnumerable);
}
}

private void DictionaryAssert(IDictionary expected, IDictionary actual)
{
Assert.AreEqual(expected.Count, actual.Count);
Expand Down
Loading