DYN-8575: Fix port context menu when switching windows #16763
+49
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds event handlers to close the port context menu when the Dynamo/Revit window loses focus, preventing it from floating above other windows. No changes to existing in-canvas behaviour.
github-actions
bot
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8575
- make sure we are unsubscribing using the Dispose pattern
Contributor
|
Can you confirm if the change also works in custom node workspace? |
Added logic to destroy the port context menu when the window is deactivated or the WorkspaceView loses focus. This ensures context menus do not remain open even when switching tab inside Dynamo
Author
Yes it does ! When switching tab inside Dynamo too now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
PR in response to [DYN-8575] (https://jira.autodesk.com/browse/DYN-8575).
This update ensures that the port context menu behaves consistently with standard UI expectations. By closing the menu whenever the Dynamo window loses focus, it avoids situations where the menu stays visible above other windows, which could confuse users or obstruct other applications. The change is minimal and does not modify any in-canvas interactions or existing menu logic.
Declarations
Check these if you believe they are true
Release Notes
Added event handlers to automatically close the port context menu when the Dynamo window loses focus.
Prevents the menu from remaining open and floating above other application windows.
No changes were made to existing in-canvas behaviour.
Reviewers
@zeusongit
FYIs
@dnenov