Skip to content

Fixes UTF-16 encoded .addin manifests fail upon loading (#70) #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spitznagel wants to merge 1 commit into
base: Revit2017
Choose a base branch
from
Open

Fixes UTF-16 encoded .addin manifests fail upon loading (#70) #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/Framework/Runner/AddinHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,12 @@ static class AddinHelpers
public static void FullyQualifyAddinPaths (FileInfo copiedAddinFile, FileInfo originalAddin)
{
XmlDocument doc = new XmlDocument();
doc.Load(copiedAddinFile.FullName);
using (StreamReader streamReader = new StreamReader(copiedAddinFile.FullName, true))
{
doc.Load(streamReader);
}

foreach(XmlElement addinElement in doc.DocumentElement.ChildNodes)
foreach (XmlElement addinElement in doc.DocumentElement.ChildNodes)
{
//if this element is an addin attempt to make the assembly path a full path
if (addinElement.LocalName != "AddIn")
Expand Down