Adding_abandoned_cart_to_chimpy #86
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this bump we needed to bump RSpec to a version that was greater than 2.99. Reason being that Railties requirement for RSpec sub 3.0 is 4.1.x and Spree at 3.0 requires a Railties version of at least 4.2.
When running specs/terminal commands in OSX, this gem spews odd "errors". Specify which notification gem to use depending on platform.
Clean up the spec helper and spree helper to actually allow the tests to pass/the tests to actually start.
The 3.1 branch still doesn't play super nicely with things. Bump back to the most recent, 2.xx branch.
Admin User section has changed a wee bit in Spree 3.0. Also the bump on Capybara might have an issue with all of this. Regardless, fixed.
Spree internals, concerning the views is a little different in 3.0. No more footer, and just focus on the header. Also some of these css classes smell of bootstrap.
Clean up user spec according to the friendly code sniffer, RuboCop.
Remove the around update call to the Spree user. This could cause some isssues when a user is frequently updated. Move the user tests over to allow and away from should syntax.
The removal of resubscribe will break this part of the subscription spec. Remove the expectations of resubscribe to clean up the test.
Feel free to run your own node and ruby versions.
No SSL Verification is required during the testing runs. Clients however, should be running SSL on their store fronts.
The API will only return at max 30 list names for pattern matching. If a store has more than 30 lists, then the likelyhood of the pattern matching to be successful is limited. Encourage the user to use the list id instead.
Update gemspec to support Spree 3.1
Add ability to make customer segment functionality optional on list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.