Add instructions on how to watch for test failures to triage docs#6610
Open
Add instructions on how to watch for test failures to triage docs#6610
Conversation
And remove reference to Jenkins since, while used, is done as part of a Github Action, and thus there's no separate place to look for failures.
| @@ -36,9 +36,11 @@ | |||
|
|
|||
Contributor
There was a problem hiding this comment.
And remove reference to Jenkins since, while used, is done as part of a Github Action, and thus there's no separate place to look for failures.
nit: Generally the body should stand on its own, including repeating what is in the title if necessary: i.e., best to not start it with "And". The title is not always right there depending on what history tool is used.
| - Do this by going to the Github Actions page: https://github.com/DynamoRIO/dynamorio/actions. | ||
| - If flaky tests are failing too often, assign someone to fix them ASAP, or mark them to be ignored in `runsuite_wrapper.pl`. | ||
| - Watch merges to master for failures on the longer test suite. | ||
| - Do this by watching for merges on the dynamorio-devs@ list. |
Contributor
There was a problem hiding this comment.
No need to look at the devs list. These are on the same Actions page linked above, to find details -- but the summary page is the green check or red X by each commit at https://github.com/DynamoRIO/dynamorio/commits/master/ . That's what the goal is: to have that page contain nothing but green checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And remove reference to Jenkins since, while used, is done as part of a Github Action, and thus there's no separate place to look for failures.