patch "Possible unsafe assignment to a non-final static field in a co…

…nstructor." from Codacy
Dyskal · Feb 27, 2021 · a487bd2 · a487bd2
1 parent dee4260
commit a487bd2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/main/java/dyskal/AppIdChooser.java b/src/main/java/dyskal/AppIdChooser.java
@@ -8,7 +8,7 @@
 import java.util.Objects;
 
 public class AppIdChooser extends JFrame {
-    private static String applicationId;
+    private String applicationId;
     private final TomlManager tomlManager = new TomlManager();
 
     public AppIdChooser() {
@@ -73,7 +73,7 @@ public AppIdChooser() {
         frame.setVisible(true);
     }
 
-    public static String getAppId() {
+    public String getAppId() {
         return applicationId;
     }
 

diff --git a/src/main/java/dyskal/DiscordRP.java b/src/main/java/dyskal/DiscordRP.java
@@ -20,7 +20,7 @@ public DiscordRP() {
 
         DiscordRPC lib = DiscordRPC.INSTANCE;
         DiscordEventHandlers handlers = new DiscordEventHandlers();
-        lib.Discord_Initialize(AppIdChooser.getAppId(), handlers, true, null);
+        lib.Discord_Initialize(new AppIdChooser().getAppId(), handlers, true, null);
 
         DiscordRichPresence presence = new DiscordRichPresence();
         presence.startTimestamp = System.currentTimeMillis() / 1000;