Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces Tailwind CSS integration, React Router configuration, and API communication on the movies page. Key changes include:
- Migration of Vite configuration to use Tailwind CSS.
- Addition of type definitions for movie data.
- Creation of new pages (Home, Movies, NotFound), layout, and navbar components with dynamic routing.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| webstudy/vite.config.ts | Updated configuration to import Tailwind CSS plugin instead of React plugin. |
| webstudy/src/types/movie.ts | New type definitions for movie and movie response data. |
| webstudy/src/pages/not-found.tsx | New NotFound page for handling unspecified routes. |
| webstudy/src/pages/movies.tsx | New Movies page that fetches popular movie data and renders a list. |
| webstudy/src/pages/home.tsx | New Home page component. |
| webstudy/src/layout/root-layout.tsx | New layout component that integrates navbar and routing outlet. |
| webstudy/src/index.css | Updated CSS to import Tailwind CSS. |
| webstudy/src/component/navbar.tsx | New navbar component with links to Home and Movies pages. |
| webstudy/src/App.tsx | Configured React Router with nested routes including an error element. |
| webstudy/package.json | Updated dependencies to include Tailwind CSS, axios, and react-router-dom. |
| useEffect(() => { | ||
| const fetchMovies = async () => { | ||
| const {data} = await axios.get<MovieResponse>( | ||
| `https://api.themoviedb.org/3/movie/popular?language=ko-KR&&page=1`, |
There was a problem hiding this comment.
The URL query string contains '&&' instead of a single '&', which may lead to incorrect API request behavior. Please replace '&&' with '&' to conform with standard URL parameter syntax.
Suggested change
| `https://api.themoviedb.org/3/movie/popular?language=ko-KR&&page=1`, | |
| `https://api.themoviedb.org/3/movie/popular?language=ko-KR&page=1`, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🏁 요약
✨ 주요 내용
이후에 처리해볼것
- 유저가 이상한 경로에 접근 시 홈으로 이동시킬 수 있는 버튼제작
- 각 페이지 별 다른 에러 처리
- ErrorBoundary처리